Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where generic params that are mut can never be satisfied by the caller #865

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

cburgdorf
Copy link
Collaborator

What was wrong?

If generic parameters are marked as mut there is currently no way to call them as the analyzer doesn't recognize them as the same type.

How was it fixed?

Threw a bunch more deref() around

@cburgdorf cburgdorf marked this pull request as ready for review April 7, 2023 09:07
@cburgdorf cburgdorf requested a review from g-r-a-n-t April 7, 2023 09:26
Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sbillig sbillig merged commit 44b2f54 into ethereum:master Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants